search

canonical / kfp-operators

Kubeflow Pipelines Operators
Apache License 2.0
2 stars 12 forks source link

Expose configuration of kfp-api's launcher and driver images in charm config in `main` #452

Closed ca-scribner closed 5 months ago

ca-scribner commented 5 months ago

Context

https://github.com/kubeflow/pipelines/pull/10269 enables administrators to configure the images used for kfp's launcher and driver containers - we need to expose that configuration as charm config so that users can use their own custom images. This is important mainly for airgapped deployments, where these will be pulled from a local container registry.

The UX of this is up to the developer. These could be exposed either each as their own config, or as a dict like in istio-pilot - whichever feels more natural for the UX. The charm should default to the current upstream images.

In completing this task, we must also update tools/get-images.sh to include these images, that way when doing routine scanning or building an airgapped tarball these images are included.

What needs to get done

.

Definition of Done

  1. config for launcher and driver images is exposed
  2. get-images.sh script is updated to include these images
  3. charm is in main
syncronize-issues-to-jira[bot] commented 5 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5637.

This message was autogenerated