search

canonical / kfp-operators

Kubeflow Pipelines Operators
Apache License 2.0
2 stars 12 forks source link

fix(ci): Clean lxc instances on bundle integration tests #612

Closed orfeas-k closed 3 days ago

orfeas-k commented 5 days ago

More details on the issue.

Fix #602

Testing

This is essentially verified on the PR's CI run. In order to verify that it doesn't affect running locally (without --clean-lxc-instances), you can try triggering a run without it. Note that the CI can fail due to #601.

orfeas-k commented 3 days ago

After discussions with @NohaIhab , we decided to drop this PR in favor of #616 for a more deterministic and less error prone approach, given that the script did some assumptions (e.g. the startswith("charmcraft") part)

    lxc_instances_charmcraft = jq.compile('.[] | select(.name | startswith("charmcraft-")) | .name').input_text(lxc_instances).all()