search

canonical / kratos-operator

Charmed Ory Kratos
https://charmhub.io/kratos
Apache License 2.0
4 stars 2 forks source link

Send public ingress url in `kratos-info` relation #267

Closed natalian98 closed 1 month ago

natalian98 commented 2 months ago

Enhancement Proposal

We should send the public ingress url in the kratos-info relation instead of the internal address: https://github.com/canonical/kratos-operator/blob/2d46f228e572f4fa9779db2ece99f587288ca0cb/src/charm.py#L474-L477

This breaks the oathkeeper integration

syncronize-issues-to-jira[bot] commented 2 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-1066.

This message was autogenerated

natalian98 commented 2 months ago

As suggested by @nsklikas, we can also point the redirect to the login ui url once https://github.com/canonical/identity-platform-login-ui/issues/247 is fixed.

shipperizer commented 1 month ago

due to how kratos-info is used we can simply swap the 2 fields in the payload to use the ingress value

https://github.com/canonical/kratos-operator/blob/main/lib/charms/kratos/v0/kratos_info.py#L107C42-L108

this should sort out oathkeeper issue