search

canonical / kserve-operators

Charmed KServe
4 stars 2 forks source link

Add relation and expose metrics from kserve-controller #254

Closed rgildein closed 2 months ago

rgildein commented 3 months ago

Context

The kserve-controller deployment provides options here to enable metrics, however charm is not using this and do not provide metrics-endpoint and grafana-dashboard endpoints.

We need to add relation using prometheus_scrape and grafana_dashboard interfaces.

Note: Only maintained alert rule or Grafana dashboard should be selected, others should be avoided.

What needs to get done

  1. Expose port for metrics as ServicePort
  2. Implement metrics-endpoint endpoint
  3. Implement grafana-dashboard endpoint
  4. [Optional] Find and add alert rules for metrics from upstream
  5. [Optional] Find and add Grafana dashboards for metrics from upstream

Definition of Done

  1. kserve-controller has metrics-endpoint and grafana-dashboard endpoints
  2. Integration with cos is tested
syncronize-issues-to-jira[bot] commented 3 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6005.

This message was autogenerated

rgildein commented 2 months ago

Closed by #261