Closed ca-scribner closed 7 months ago
PR is missing the tox.ini/tests folder. will add these next before merging this. But the rock itself works afaict in local testing
PR is now ready for review, with proper tests. Any CI failures now are not intentional
adds a rock for the kserve v0.11 sklearnserver based on this dockerfile and the existing Paddle and pmmlserver rocks
This PR refactors a little compared to the previous rocks like pmmlserver. The main goals were:
python3
)Specifically for the
pythonpath
, the pmmlserver rock needs to add/pmmlserver:/kserve
to its servicePYTHONPATH
because poetry by default installs a root project as editable, which means the code is not stored indist-packages
like the other installed packages. So when we copy our installed python packages from build env to the final rock in pmmlserver, we omit the pmmlserver and kserve packages (and then we "fix" that by copying the code separately, and adding the new code dirs toPYTHONPATH
.I'm worried this
PYTHONPATH
workaround might have unintended consequences, so instead in this rock I install kserve and sklearnserver packages as local dependencies of a dummy poetry project rather than as root projects. This tricks poetry into installing them normally (not editable), which means they are put indist-packages
like everything else.Testing instructions
The rock should launch, but then fail with: