search

canonical / kserve-rocks

ROCKs for Kserve
0 stars 1 forks source link

feat: add controller rock (v0.11.2) #48

Closed NohaIhab closed 6 months ago

NohaIhab commented 6 months ago

closes #32

NohaIhab commented 6 months ago

@DnPlas that's odd, is there no output from the pack command? maybe try rockcraft pack -v for logs?

NohaIhab commented 6 months ago

@DnPlas you can download the rock from the CI's artifacts in the meantime

NohaIhab commented 6 months ago

On another topic, I saw at the beginning you defined an entrypoint, but that caused an issue, do you know why it was the case for you and not for other rocks? For instance, this one.

@DnPlas defining an entrypoint did not cause an issue, it's just unnecessary when we are not expecting additional arguments to be passed to the container when it's being started. See the rockcraft docs.