search

canonical / kubeflow-ci

Tools and tests for managing the Charmed Kubeflow bundle
Apache License 2.0
2 stars 8 forks source link

unify `tox` environment for dependency update #59

Open beliaev-maksim opened 1 year ago

beliaev-maksim commented 1 year ago

Currently we have different env ([testenv:update-requirements]) for reqs.txt updates in tox

we need a canon run to unify them across all repos. Things to consider:

  1. same resolver everywhere
  2. consider -U option (or add separate env)
  3. fix (or clean up afterwards) all the comment lines. It should be aligned with renovate style to avoid noise in PRs (example PR)

image

ca-scribner commented 1 year ago

@beliaev-maksim did your most recent work solve this? I can't remember if you pushed it to just one repo, or all repos

beliaev-maksim commented 1 year ago

@ca-scribner no, I still wait for review in argo

beliaev-maksim commented 1 year ago

need to run the change proposed in https://github.com/canonical/argo-operators/pull/100 for all the repos

orfeas-k commented 1 year ago

Do these PRs solve this issue? If not, is there a list of repos, we need to send PRs for?

beliaev-maksim commented 1 year ago

@orfeas-k they do. Was it applied to all repos?

orfeas-k commented 1 year ago

Made this list of all MLOps repos (excluding ROCKs) and I 'll try to go through it the next days and note which ones need a PR for this issue to close.