search

canonical / kubeflow-rocks

Rocks for Kubeflow components
Apache License 2.0
0 stars 11 forks source link

Added `pvcviewer-controller` rock #130

Open TakoB222 opened 2 months ago

TakoB222 commented 2 months ago

Description

misohu commented 1 month ago

Hi @TakoB222 before we proceed we approval of this PR can you please make sure the rock is working with existing charm. You can do it by running integration tests from the pvc viewer repo.

  1. Deploy microk8s 1.29-strict/stable
  2. Connect it with juju 3.4/stable
  3. Create kubeflow model (if you will have problems with the juju setup please try this step by step guide until model deployment )
  4. publish rock to your dockerhub e.g. tacko/pvc-viewer
  5. In the charm repo replace this line with your rock image from your dockerhub.
  6. Run the tox integration test and keep the model tox -vve integration -- --model kubeflow --keep-models

All the tests should be green. After successfully running the tests please can you provide the output of juju status. When we develop in our team that is the way how we test that the rock is ready.