canonical / kubeflow-rocks

Rocks for Kubeflow components

Apache License 2.0

0 stars 11 forks source link

fix: update command and env variables #55

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

Description

Jupyter notebook ROCK are not functionining properly because environment variables are not used in the command AND are set in environment for the service.

More details in: https://github.com/canonical/kubeflow-rocks/issues/54

Summary of changes:

Updated environments in all Jupyter notebook server ROCKs to omit envirtonmen variables that need to be set in the Pod environment. Added comment indicating this.
Updated command to expand environment variables.

kimwnasptd commented 1 year ago

@i-chvets also, let's extend here the sanity checks to use this ENV var and test that notebooks are serving from a prefix as expected