canonical / kubeflow-rocks

Rocks for Kubeflow components

Apache License 2.0

0 stars 11 forks source link

Update env vars in rocks #61

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

Description

There was an issue discovered with latest ROCKs that incorrectly stored notebooks: https://github.com/canonical/notebook-operators/issues/312

In order to resolve the issue environment variable HOME needs to be set properly.

Summary of changes:

Set HOME environment variable and sync it with working-dir
Updated version field to include dashes because of recent Rockcraft changes.

NohaIhab commented 1 year ago

Hi @i-chvets I tried out the jupyter-scipy rock but I still don't see the working directory as expected, and files do not persist when stopping the notebook I published it to charmedkubeflow/jupyter-scipy-test:v1.7.0-20.04-1 if you want to play around with it.

i-chvets commented 1 year ago

Tested with the test ROCK image pushed to registry: https://hub.docker.com/r/charmedkubeflow/jupyter-pytorch-full-test/tags

Screenshot from 2023-10-31 10-32-46

@NohaIhab Could you verify on your end with the above ROCK image.

SamirPS commented 1 year ago

Hello

With @i-chvets image, I have the good PWD, but with @NohaIhab image, I have the wrong PWD. Noha, can you use rockcraft clean before rebuilding the image?

NohaIhab commented 1 year ago

Confirming the above, the published rock charmedkubeflow/jupyter-pytorch-full-test:v1.7.0-20.04-1 has the right pwd and the files persist when stopping and starting the notebook. Just a small comment, the user in a terminal created from a notebook is not the same as upstream, but I wouldn't block on this. I don't see it affecting the functionality.