search

canonical / kubeflow-rocks

Rocks for Kubeflow components
Apache License 2.0
0 stars 11 forks source link

Build sklearnserver #8

Closed rbarry82 closed 1 year ago

rbarry82 commented 1 year ago

Execution (finally) gives the same output as the upstream image, which is admittedly a Python exception because there's no JOBLIB_FILE from some seldon_core...model_uri, but it's close to a working model if not completely there.

Primarily, Conda inside craft is an adventure for a lot of reasons, and while this is the first Rockcraft YAML which successfully jumps through all the right hoops, the patterns here (principally the subshell, invoking seldon-core-microservice .., another subshell during pebble exec) will almost certainly be needed in other Seldon images, and/or other Conda images.

rbarry82 commented 1 year ago

@i-chvets @ca-scribner @andreeamun @kimwnasptd @DnPlas

i-chvets commented 1 year ago

We should move this PR to this repo https://github.com/canonical/seldonio-rocks

rbarry82 commented 1 year ago

Also true for the other seldon PRs here?

Yes. There is only one more https://github.com/canonical/kubeflow-rocks/pull/2

DnPlas commented 1 year ago

Thanks @rbarry82 ! I will close this PR in favour of https://github.com/canonical/seldonio-rocks/pull/3, we will continue the work in that one, but really appreciate your contributions.