search

canonical / kubeflow-tensorboards-operator

Tensorboards Operator
Apache License 2.0
2 stars 5 forks source link

tests(twa): Replace istio in integration tests #102

Open orfeas-k opened 5 months ago

orfeas-k commented 5 months ago

Context

During https://github.com/canonical/bundle-kubeflow/issues/621, it was agreed to test web apps charms by using the unit/k8s-svc IP directly instead of going through istio's ingressgateway. Thus, we should remove istio charms from integration tests. However, kubeflow-tensorboards-webapp charm needs ingress relation in order to be unblocked and go to active. Thus, it should be replaced instead by a test entity that will be able mock that relation.

By removing istio, tests will also be independent of istio charms' failures.

What needs to get done

  1. Remove istio from tensorboards-web-app
  2. Replace it with a mock charm that offers ingress relation to charm

Definition of Done

Charm's integration tests pass without deploying istio charms

syncronize-issues-to-jira[bot] commented 5 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5279.

This message was autogenerated

orfeas-k commented 5 months ago

We could also replace istio in the repo's integration tests.