canonical / kubeflow-tensorboards-operator

Tensorboards Operator
Apache License 2.0
2 stars 5 forks source link

feat: Rewrite the Tensorboards Web App charm following the sidecar pattern #74

Closed orfeas-k closed 1 year ago

orfeas-k commented 1 year ago

This PR rewrites the Tensorboards Web App (TWA) charm following the sidecar pattern In short:

Upgrade instructions

  1. Trust the charm
    juju trust tensorboards-web-app
  2. Refresh the charm providing: i. the image since oci-image was changed to tensorboards-web-app-image. ii. the path to the local charm or the corresponding channel (for charms released in charmhub)
    juju refresh tensorboards-web-app --resource tensorboards-web-app-image=kubeflownotebookswg/tensorboards-web-app:v1.7.0 --path="./tensorboards-web-app_ubuntu-version-arch.charm" 

    or

    juju refresh tensorboards-web-app --resource tensorboards-web-app-image=kubeflownotebookswg/tensorboards-web-app:v1.7.0 --channel=track/risk
ca-scribner commented 1 year ago

Extremely pedantic suggestion for the upgrade instructions :)

juju refresh tensorboards-web-app ... --channel=version/mode

should be

juju refresh tensorboards-web-app ... --channel=track/risk

Doesn't change the function, but gets the terminology consistent with elsewhere.