canonical / kubeflow-volumes-operator

Volumes Operator
Apache License 2.0
0 stars 3 forks source link

Integrate the filebrowser rock into `main` #127

Closed ca-scribner closed 9 months ago

ca-scribner commented 9 months ago

This PR integrates the rock built from https://github.com/canonical/filebrowser-rock.

Contributes to #126

Testing instructions

note:

juju deploy kubeflow --channel 1.8/stable --trust

# wait for everything to settle

# Migrate to the newest charm version
juju scale-application kubeflow-volumes 0
# Wait for it to scale down
sleep 10
juju refresh kubeflow-volumes --channel latest/edge/pr-127
juju trust kubeflow-volumes --scope=cluster
juju scale-application kubeflow-volumes 1

# Configure everything else
juju config dex-auth static-username=user123
juju config dex-auth static-password=user123
juju config dex-auth public-url="http://10.64.140.43.nip.io"
juju config oidc-gatekeeper public-url="http://10.64.140.43.nip.io"

# Wait for everything to settle

# log into 10.64.140.43.nip.io using user123/user123
# go to volumes web app
# create a volume named testvol
# click the "Open PVC Viewer" button (small folder icon on the right side of the row)
# filebrowser window should open (although there will be no files since pvc is empty - you can create some though!)

# confirm we got a filebrowser with the new image:
kubectl -n user123 get pod $(kubectl get pod -n user123 --selector=app.kubernetes.io/instance=pvcviewer-testvol --output=jsonpath={.items..metadata.name}) -o yaml | grep filebrowser:
# Should return:
filebrowser:
    image: docker.io/library/charmedkubeflow/filebrowser:v2.27.0
    image: docker.io/library/charmedkubeflow/filebrowser:v2.27.0

# NOT
filebrowser:
    image: docker.io/library/filebrowser/filebrowser:v2.23.0
    image: docker.io/library/filebrowser/filebrowser:v2.23.0
ca-scribner commented 9 months ago

Ready as soon as https://github.com/canonical/filebrowser-rock/pull/2 merges and publishes

ca-scribner commented 9 months ago

Now ready