[DPE-4472] Pin the same version of rock image everywhere in Kyuubi charm

canonical / kyuubi-k8s-operator

Charmed K8s operator for Apache Kyuubi for to be deployed and managed by juju

Apache License 2.0

1 stars 2 forks source link

[DPE-4472] Pin the same version of rock image everywhere in Kyuubi charm #19

Closed theoctober19th closed 3 months ago

deusebio commented 3 months ago

not a bit fan of this. I mean: when we update this we need to remember to update 3 places. Can we put some logic to fetch this info directly from metadata.yaml?

welpaolo commented 3 months ago

I agree can you try to find an automatic way to propagate this info ?

theoctober19th commented 3 months ago

Yes, I can definitely do that. Would there possibly be cases where we would want the pod image to be different from charm image (eg, possibly some changes in spark k8s toolkit we may require in Pod, but we are not ready to pin the new revision in charm metadata just yet)?

deusebio commented 3 months ago

uhm, not sure. But if any, we will revisit this. But even then, pinning would be quite good anyway such that we don't break CI when releasing new images.