search

canonical / kyuubi-k8s-operator

Charmed K8s operator for Apache Kyuubi for to be deployed and managed by juju
Apache License 2.0
1 stars 2 forks source link

[DPE-3007] Add Support to use PostgreSQL as Hive Metastore #6

Closed theoctober19th closed 5 months ago

theoctober19th commented 5 months ago

Add support to use PostgredSQL as Hive Metastore by integrating kyuubi-k8s with postgresql-k8s.

theoctober19th commented 5 months ago

The PR looks good. I left some minor comments. I believe that we are missing some integrations tests:

  • Removal of integration with PostgreSQL and check that everything is working
  • Integrating again with PostgreSQL and check the existence of the previously created tables and everything is working properly

I have added a test for 1. However, as we discussed yesterday, since we do not guarantee the persistence / removal of metadata upon the change of metastore from A to B to A back again, I have skipped 2 at the moment. WDYT @welpaolo @deusebio ?

deusebio commented 5 months ago

That's fine by me! We can maybe just have a tech debt in the backlog for this though. The use case that Paolo is suggesting is relevant, but a nice to have at the moment

welpaolo commented 5 months ago

Fine with me as well!