Fixing filebeat holding onto old file descriptors

canonical / layer-filebeat

Filebeat is a lightweight log shipper. This is the source for the filebeat charm in the Juju charm store.

Other

3 stars 27 forks source link

Fixing filebeat holding onto old file descriptors #109

Closed al3jandrosg closed 1 month ago

al3jandrosg commented 7 months ago

Under certain scenariosFilebeat may hold onto old log file descriptors. There are various settings on Filebeat to prevent this from happening. This patch adds to the charm two key settings that help prevent this issue:

ignore_older
clean_inactive

Note that while these configuration parameters used to not be specified in the filebeat config files, they will now always be rendered. The charm configuration however aligns with the upstream defaults so this is not expected to alter behavior of existing deployments upon upgrading.

Fixing: #87

al3jandrosg commented 2 months ago

@aieri any feedback on the latest changes by any chance? I am looking forward to pushing this forward as my customer is frequently having issues.

aieri commented 2 months ago

@aieri any feedback on the latest changes by any chance? I am looking forward to pushing this forward as my customer is frequently having issues.

hey sorry for the lack of reviews. This PR was somehow still listed as waiting for your changes in our board, which meant nobody would have picked it up during their normal daily reviews

aieri commented 2 months ago

@al3jandrosg I would also add that although it's true that this charm does not have unit tests, I think your change should come with some (for its own functions). I have created #111 for this reason, so once that one is merged please rebase and add your tests.

aieri commented 1 month ago

force merging since we agreed that unit tests will be coming in a separate PR