search

canonical / layer-filebeat

Filebeat is a lightweight log shipper. This is the source for the filebeat charm in the Juju charm store.
Other
3 stars 27 forks source link

Reinstate silently dropped Xenial (16.04) support #99

Closed barryprice closed 1 year ago

barryprice commented 2 years ago

It looks like Ubuntu Xenial (16.04) support was quietly dropped in commits https://github.com/juju-solutions/layer-filebeat/commit/564f6e5a0804ede2dad4eebad9082858a520db63 and https://github.com/juju-solutions/layer-filebeat/commit/8a9aef4dc5aac9ff0284902f72d9b6bd40ab80b0, but this series is still supported via ESM.

This PR will reinstate it via charmcraft.yaml, and also pins the MarkupSafe library to <2.0.0 for py35 compatibility (Xenial provides Python 3.5.2).

Pjack commented 1 year ago

Is there any reason to support 16.04? If customer stick in 16.04 for ESM, they can install rev33. For most of charm, 16.04 are deprecated and not compatible with juju < 3.0. I prefer to reject this PR. Thanks for your understanding.

Pjack commented 1 year ago

@barryprice I will close this PR before end of March if there is no further response. Basically, xenial is out of our support score. We won't fix it unless there is strong business requirements and we cannot resolve it from older revision.