canonical / lego-base-k8s-operator

Base library for building Lego Kubernetes operators
https://charmhub.io/lego-base-k8s
Apache License 2.0
0 stars 3 forks source link

chore: Removes condition for extracting no_proxy juju model config #150

Closed saltiyazan closed 1 month ago

saltiyazan commented 1 month ago

Description

@shipperizer requested to remove this condition as sometimes on http proxy is not needed, only https. Added some logs too to ensure the command gets the env vars.

Checklist:

shipperizer commented 1 month ago

changes are needed to get more visibility of the "shell" context in which the command is executed

regarding the dropping of the and condition on the setting of no_proxy that is meant avoid hiddent conditions where one of http or https proxy vars are not set and we want proxying only for one of the protocols