canonical / lightdm

Display Manager
GNU General Public License v3.0
827 stars 138 forks source link

Allow Wayland sessions to start on seat0 on kernels with no VTs #315

Closed n3rdopolis closed 6 months ago

n3rdopolis commented 1 year ago

This is an attempt to fix #314

github-actions[bot] commented 1 year ago

Everyone contributing to this PR have now signed the CLA. Thanks!

n3rdopolis commented 1 year ago

Wait It looks like it wants my dang address to be able to merge?

n3rdopolis commented 1 year ago

It's only a few lines, so you do have my permission to use it, but I don't want to fill out my address and whatnot

qwertychouskie commented 1 year ago

I never even noticed the CLA had an address and phone field, probably because I just instinctively put something random like every other webform. Unless you like plan on signing an employment agreement with Canonical in the future or something, name/username and country is functionally just fine.

I'd like to see these fields removed, but there's probably some weird lawyery reason they can't officially remove the fields.

(I'd still take Canonical's CLA approach to things any day over Red Hats' [bleep]-the-GPL-you-are-not-rich-enough-to-sue-us-anyways approach.)

n3rdopolis commented 1 year ago

I never even noticed the CLA had an address and phone field, probably because I just instinctively put something random like every other webform. Unless you like plan on signing an employment agreement with Canonical in the future or something, name/username and country is functionally just fine.

I'd like to see these fields removed, but there's probably some weird lawyery reason they can't officially remove the fields.

(I'd still take Canonical's CLA approach to things any day over Red Hats' [bleep]-the-GPL-you-are-not-rich-enough-to-sue-us-anyways approach.)

OK, It also seems to want a "Please add the Canonical Project Manager or contact" which I have no idea what to fill in for that? Maybe lightdm?

JezerM commented 1 year ago

OK, It also seems to want a "Please add the Canonical Project Manager or contact" which I have no idea what to fill in for that? Maybe lightdm?

Yeah, that's a weird field. I just added "Robert Ancell" as he's the main contributor of this project.

n3rdopolis commented 1 year ago

Odd that it's failing now. I wonder if I was supposed to add the ~ in the launchpad ID or not...

JezerM commented 1 year ago

You must push a new commit, or force push, to trigger the GitHub Action.

n3rdopolis commented 1 year ago

Well lets see, I did realize that I accidentally added an extra space that isn't needed, so I will remove it, repush, and see how that goes

qwertychouskie commented 1 year ago

n3rdopolis ✕ (issue checking CLA status [HttpError: User does not exist or is not a member of the organization])

Strange. Maybe @robert-ancell has some insight into the error?

JezerM commented 1 year ago

It failed xD

Make sure your Launchpad email is the same you have in GitHub. Even if the ID is the same as GitHub's, it seems it checks your email instead.

n3rdopolis commented 1 year ago

I wonder if some file has to replicate inside some server after signing it, before it is visible to Github

FunkyFinch commented 1 year ago

Are there any updates on this PR? Did you have success with your changes?

n3rdopolis commented 8 months ago

I would like to request a review on this if possible

n3rdopolis commented 8 months ago

@robert-ancell is it possible to review this please?

n3rdopolis commented 6 months ago

Are there changes that need to be made here?