search

canonical / lightdm

Display Manager
GNU General Public License v3.0
813 stars 137 forks source link

Make location of .xession-errors depend on user configuration #335

Open madpilot78 opened 6 months ago

madpilot78 commented 6 months ago

I have extended on the patch in #287 by adding a configuration file variable for lightdm to control how the location of .xsession-errors is chosen.

I added a smart-xsession-errors, which is off by default, that allows to switch from the old behavior (putting it in ~/.xsession-errors) to the algorith suggested in #287

This patch is being considered for inclusion in the freebsd ports tree for lightdm [1]. I decided to add a configuration variable and set it to false (implying old behavior), because I don't feel comfortable forcing a change of the location of this file on users. This due to the fact that the location of this file is historical behavior and expected by the users.

[1] https://bugs.freebsd.org/266532 and https://bugs.freebsd.org/275885

github-actions[bot] commented 6 months ago
Hey! madpilot78 has not signed the Canonical CLA which is required to get this contribution merged on this project. Please head over to https://ubuntu.com/legal/contributors to read more about it.
madpilot78 commented 6 months ago

As in #334 I cannot claim full copyright on this, since I took part of the code from #287.

Also, I am unable to complete the CLA form, it asks for a Canonical Project Manager or contact. What should I put in this field?

Thanks in advance.

robert-ancell commented 5 months ago

@madpilot78 you can put me in the contact field, thanks!