search

canonical / lightdm

Display Manager
GNU General Public License v3.0
843 stars 139 forks source link

Add client library version for Qt6 #373

Open Gliese852 opened 3 months ago

Gliese852 commented 3 months ago

I would like to port lightdm-kde-greeter to qt6, and this requires the corresponding lightdm library.

I did not delete the version for qt5, the versions do not interfere with each other. The source code has not changed much, just updated the outdated QString::toAscii method.

Added an m4 macro to search for the moc executable file to check the version. It seems that this will be more reliable if there are several of them in the system. For reference, I used macros from the freeciv project. (qt6.m4)

github-actions[bot] commented 3 months ago

Everyone contributing to this PR have now signed the CLA. Thanks!

Gliese852 commented 3 months ago

Well, now CI is building a version for Qt6. Tests fail just like in main; tests added for Qt6 also fail.

Gliese852 commented 2 months ago

@robert-ancell, Do I need to sign a Canonical CLA, and if so, can I use your name as a contact?

robert-ancell commented 2 months ago

@Gliese852 yes, you will need to sign the CLA and you can use my name. Thanks!

Gliese852 commented 2 months ago

Squashed the fixup commits to at the same time provoke the launch of CI, at least the cla-check is now successful.