canonical / lightdm

Display Manager
GNU General Public License v3.0
843 stars 139 forks source link

Debian folder was not correctly updated for release 1.32.0 #377

Open vaab opened 2 months ago

vaab commented 2 months ago

I tried to build a debian package (using debuild -us -uc) but got this error:

make[1]: Entering directory '/home/vaab/dev/c/lightdm'
rm -r debian/tmp/usr/share/help/C/
# we do install pam through installpam and init through installinit
dh_install -X.a -X.la -Xpam.d -X'etc/init/lightdm.conf' --fail-missing
dh_install: warning: Compatibility levels before 10 are deprecated (level 9 in use)
dh_install: warning: Please use dh_missing --list-missing/--fail-missing instead
dh_install: warning: This feature will be removed in compat 12.
dh_install: warning: Cannot find (any matches for) "etc/dbus-1/" (tried in ., debian/tmp)

dh_install: warning: lightdm missing files: etc/dbus-1/
dh_install: error: missing files, aborting
make[1]: *** [debian/rules:28: override_dh_install] Error 255
make[1]: Leaving directory '/home/vaab/dev/c/lightdm'
make: *** [debian/rules:6: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
debuild: fatal error at line 1184:
dpkg-buildpackage -us -uc -ui failed

This is likely due to what is reported in NEWS for release 1.32.0 here.

When replacing:

diff --git a/debian/lightdm.install b/debian/lightdm.install
index 87d0e2de..d472dbd9 100644
--- a/debian/lightdm.install
+++ b/debian/lightdm.install
@@ -7,7 +7,7 @@ usr/share/locale
 usr/share/polkit-1
 usr/lib/lightdm
 usr/bin
-etc/dbus-1/
+usr/share/dbus-1/system.d/
 etc/lightdm/users.conf
 etc/lightdm/lightdm.conf usr/share/doc/lightdm/
 etc/lightdm/keys.conf usr/share/doc/lightdm/

The package will build.

Of course a new changelog entry is also required.