add public method to `LogForwarder` to retrieve the full endpoint urls

canonical / loki-k8s-operator

This charmed operator automates the operational procedures of ryunning Grafana Loki, an open-source logs backend, in monolithic mode

https://charmhub.io/loki-k8s

Apache License 2.0

10 stars 16 forks source link

add public method to `LogForwarder` to retrieve the full endpoint urls #401

Open PietroPasotti opened 4 months ago

PietroPasotti commented 4 months ago

we only have a private: _retrieve_endpoints_from_relation method.

To facilitate integration with e.g. charm logging utils, we should be able to access the endpoints from the parent object (the charm).

_Originally posted by @Abuelodelanada in https://github.com/canonical/loki-k8s-operator/pull/392#discussion_r1589546430_

lucabello commented 2 months ago

That function was intentionally made private because we didn't want charms to use that. We can go back on that decision, but I'd rather have an ADR on that to make sure the team's on the same page :)