canonical / lxd-ui

Easy and accessible container and virtual machine management. A browser interface for LXD
GNU General Public License v3.0
242 stars 30 forks source link

Update react components #774

Closed edlerd closed 1 month ago

edlerd commented 1 month ago

Done

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • test empty state

Screenshots

New instance empty state image

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

mas-who commented 1 month ago

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Screenshot from 2024-05-22 13-48-52

edlerd commented 1 month ago

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Good catch, side panels are a special case. I updated them to be full width. Please check again.

mas-who commented 1 month ago

Thanks for this update. I think the empty state looks fine on normal pages but seems to be a bit far to the right in side panels. Should we collapse the left margin for empty state in side panels?

Good catch, side panels are a special case. I updated them to be full width. Please check again.

Yeah I think it looks pretty good now :+1: