canonical / lxd-ui

Easy and accessible container and virtual machine management. A browser interface for LXD
GNU General Public License v3.0
242 stars 30 forks source link

[WD-10833] - Indicate logged-in-user-email #779

Closed Kxiru closed 1 month ago

Kxiru commented 1 month ago

Done

Pending Design Draft

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Upon running LXD through a TLS connection, you should see "lxd-ui.crt" next to a lock icon, in the navigation bar.
    • Upon running LXD through an OIDC connection, you should see your username in the navigation bar. If you do not have an associated username, you should see your email address, which will likely be truncated depending on length.

Screenshots (updated)

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

piperdeck commented 1 month ago

Hi @Kxiru, could you please post screenshots of the QA steps? I wasn't able to stand up a testing lxd instance in order to test the OIDC behaviour, but I'd really like to review this for you.

Kxiru commented 1 month ago

Hi @Kxiru, could you please post screenshots of the QA steps? I wasn't able to stand up a testing lxd instance in order to test the OIDC behaviour, but I'd really like to review this for you.

I've added updated screenshots to the PR description for you.

piperdeck commented 1 month ago

LGTM