canonical / lxd-ui

Easy and accessible container and virtual machine management. A browser interface for LXD
GNU General Public License v3.0
242 stars 30 forks source link

[WD-11261] Implementation of LXD PWA with a dynamic start_url #785

Closed Kxiru closed 1 month ago

Kxiru commented 1 month ago

Done

Specification: LX078 - PWA Support

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Open the LXD-UI Client and note the PWA pop up, or, view the image --icon in the url toolbar. One can click this to trigger the installation sequence.

Screenshots

image image image

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

mas-who commented 1 month ago

@Kxiru I think David has covered all the points. After making the changes for the screenshot reference path, it should work on the demo server as well.

In case if you are wondering why the path should be changed, you can go to the Source tab in your chrome inspector (see below for reference)

Screenshot from 2024-05-30 09-57-49

Edit: Can you also ask @piperdeck to do a test on Safari for this.

Kxiru commented 1 month ago

@edlerd , I've got it to work on the demo server and I've tidied up index.html a bit too :).