search

canonical / lxd-ui

Easy and accessible container and virtual machine management. A browser interface for LXD
GNU General Public License v3.0
242 stars 30 forks source link

[WD-11691] chore: minor UI change for vertical navigation resizing. #797

Closed Kxiru closed 3 weeks ago

Kxiru commented 1 month ago

Done

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • N/A

Screenshots

image

image

webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

Kxiru commented 3 weeks ago

On the demo server, the navigation doesn't scroll any more. I.e. when I shrink the browser windows height the lower part of the nav stays visible as required, but the middle part is cur with no way of reaching the hidden nav items. Is the demo not updated, or is it a problem with the changes?

That is interesting... On my local computer and when I run the demo server, I am getting the correct behaviour. @mas-who could you please confirm what you see?

@edlerd , this is the main thing that I had issue with fixing earlier, but I have corrected this and done extensive testing since then. (As well as cleared my cache lol)

Kxiru commented 3 weeks ago

That being said, I have found that the top container is not scrollable. I added a fixing line for this in my last commit.