canonical / lxd-ui

Easy and accessible container and virtual machine management. A browser interface for LXD
GNU General Public License v3.0
269 stars 33 forks source link

fix: remove bulk instance migration feature due to server loading concerns #869

Closed mas-who closed 3 weeks ago

mas-who commented 1 month ago

Done

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, build and run as described in the docs.
  2. Perform the following QA steps:
    • For the UI connected to a lxd cluster, check that the Migrate button is no longer visible when selecting multiple instances on the instance list page.
webteam-app commented 1 month ago

Demo

Jenkins

demos.haus

mas-who commented 1 month ago

I am not a fan. If we remove it, we should also clean up the isBulkMigration from the MigrateInstanceModal and migrateInstanceBulk from the api/instances.tsx file.

Yeah I'm also not a huge fan of this change, but I think overloading the server is a valid point. If you don't want to merge this one, maybe when I get back we can look into processing batches of requests instead. In the interim, I've done some more cleaning up, removed all bulk migration related logic and also adjusted the modal component to process a single instance only.