search

canonical / lxd

Powerful system container and virtual machine manager
https://canonical.com/lxd
GNU Affero General Public License v3.0
4.27k stars 910 forks source link

VM: Correct QEMU device ID max length #13672

Open hamistao opened 4 days ago

hamistao commented 4 days ago

I don't think this is currently causing any bugs, but the correct limit for QEMU IDs is 63, not 64. If longer than that, QEMU truncates the ID internally.

tomponline commented 4 days ago

@hamistao to be comfortable with this change please can you double check that the /dev/disk/by-id names do not change for block disk device passthroughs. Cheers

hamistao commented 3 days ago

I beleive this is safe to merge. Both entries for the device on /dev/disk/by-id are generated from the serial name (and not the device ID), so this could not affect them

tomponline commented 3 days ago

I beleive this is safe to merge. Both entries for the device on /dev/disk/by-id are generated from the block node name (and not the device ID), so this could not affect them

Ok cool ill wait for the lxd-ci disk by id tests to be merged and passed, then merge this to check for regressions