66hades commented 4 years ago

Issue description

When executing the command "lxc project ..." no function arguments appear when using tab complete, only the contents of the pwd.

For example, executing lxc config then hitting tab produces

gardener6@borderbound3:~$ lxc config
device    edit      get       metadata  set       show      template  trust     unset
gardener6@borderbound3:~$ lxc config

and executing lxc restart will produce a list of containers (only containers that are in the current project)

I poked around trying to find a fix myself. This stackflow entry says using compgen or complete, but a brief look around LXD source code didn't net me any results. Could someone point me in the direction where this is implemented in existing lxd functions?

Steps to reproduce

Type lxc project
Press the tab key

Results of steps

gardener6@borderbound3:~/minecraft_files/Paper-ver-1.14$ lxc project
CONTRIBUTING.md        .gitignore             licenses/              README.md              Spigot-API-Patches/    work/
.editorconfig          .gitmodules            paper                  removed/               Spigot-Server-Patches/
.github/               LICENSE.md             pom.xml                scripts/               .travis.yml
gardener6@borderbound3:~/minecraft_files/Paper-ver-1.14$ lxc project

Required information

Operating System: Ubuntu 18.04.4 LTS
Kernel: Linux 5.0.0-37-generic
Architecture: x86-64

The output of "lxc info"

gardener6@borderbound3:~$ lxc info
config:
core.https_address: '[::]:8443'
core.trust_password: true
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_stop_priority
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
- resources
- kernel_limits
- storage_api_volume_rename
- macaroon_authentication
- network_sriov
- console
- restrict_devlxd
- migration_pre_copy
- infiniband
- maas_network
- devlxd_events
- proxy
- network_dhcp_gateway
- file_get_symlink
- network_leases
- unix_device_hotplug
- storage_api_local_volume_handling
- operation_description
- clustering
- event_lifecycle
- storage_api_remote_volume_handling
- nvidia_runtime
- container_mount_propagation
- container_backup
- devlxd_images
- container_local_cross_pool_handling
- proxy_unix
- proxy_udp
- clustering_join
- proxy_tcp_udp_multi_port_handling
- network_state
- proxy_unix_dac_properties
- container_protection_delete
- unix_priv_drop
- pprof_http
- proxy_haproxy_protocol
- network_hwaddr
- proxy_nat
- network_nat_order
- container_full
- candid_authentication
- backup_compression
- candid_config
- nvidia_runtime_config
- storage_api_volume_snapshots
- storage_unmapped
- projects
- candid_config_key
- network_vxlan_ttl
- container_incremental_copy
- usb_optional_vendorid
- snapshot_scheduling
- container_copy_project
- clustering_server_address
- clustering_image_replication
- container_protection_shift
- snapshot_expiry
- container_backup_override_pool
- snapshot_expiry_creation
- network_leases_location
- resources_cpu_socket
- resources_gpu
- resources_numa
- kernel_features
- id_map_current
- event_location
- storage_api_remote_volume_snapshots
- network_nat_address
- container_nic_routes
- rbac
- cluster_internal_copy
- seccomp_notify
- lxc_features
- container_nic_ipvlan
- network_vlan_sriov
- storage_cephfs
- container_nic_ipfilter
- resources_v2
- container_exec_user_group_cwd
- container_syscall_intercept
- container_disk_shift
- storage_shifted
- resources_infiniband
- daemon_storage
- instances
- image_types
- resources_disk_sata
- clustering_roles
- images_expiry
- resources_network_firmware
- backup_compression_algorithm
- ceph_data_pool_name
- container_syscall_intercept_mount
- compression_squashfs
- container_raw_mount
- container_nic_routed
- container_syscall_intercept_mount_fuse
- container_disk_ceph
- virtual-machines
- image_profiles
- clustering_architecture
- resources_disk_id
- storage_lvm_stripes
- vm_boot_priority
- unix_hotplug_devices
- api_filtering
- instance_nic_network
- clustering_sizing
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
environment:
addresses:
- 192.168.0.140:8443
- 10.177.89.1:8443
- 192.168.122.1:8443
architectures:
- x86_64
- i686
certificate: |
-----BEGIN CERTIFICATE-----
MIICFjCCAZygAwIBAgIRALm5CN9+hyWR6rny6B3ZhLkwCgYIKoZIzj0EAwMwOjEc
MBoGA1UEChMTbGludXhjb250YWluZXJzLm9yZzEaMBgGA1UEAwwRcm9vdEBib3Jk
ZXJib3VuZDMwHhcNMjAwMjA2MjE1MjQ1WhcNMzAwMjAzMjE1MjQ1WjA6MRwwGgYD
VQQKExNsaW51eGNvbnRhaW5lcnMub3JnMRowGAYDVQQDDBFyb290QGJvcmRlcmJv
dW5kMzB2MBAGByqGSM49AgEGBSuBBAAiA2IABHbtkzLoxV9GrxlkeqrGSn7pvQHC
OoGe2X+y3+a7arli8HvgY2iskSKZGv2d7Yc2pydYs67TzLwBo6A1Yf2+lq5t0Cd8
8KST+3KUdy+uSQCXYdsdWSXHRwnb8UZ9yxRwXqNmMGQwDgYDVR0PAQH/BAQDAgWg
MBMGA1UdJQQMMAoGCCsGAQUFBwMBMAwGA1UdEwEB/wQCMAAwLwYDVR0RBCgwJoIM
Ym9yZGVyYm91bmQzhwR/AAABhxAAAAAAAAAAAAAAAAAAAAABMAoGCCqGSM49BAMD
A2gAMGUCMCBn6vvsEbJvvD5MLQv8O2v+sNufj8MGVgQb6pEFpoxcMBGGY6iMz34W
6rs2BP0LigIxAJMCORmlveSWWHGtdzjNOsO2JwopnLv+cpbUs8nUyCfRqHkMW1xv
0Q0ZO5iuJVHnoQ==
-----END CERTIFICATE-----
certificate_fingerprint: caba0295930e718cabc54f2a8751ec98325af8e849c561ccc8015e7cbcebd03e
driver: lxc
driver_version: 3.2.1
kernel: Linux
kernel_architecture: x86_64
kernel_features:
netnsid_getifaddrs: "true"
seccomp_listener: "true"
seccomp_listener_continue: "true"
shiftfs: "false"
uevent_injection: "true"
unpriv_fscaps: "true"
kernel_version: 5.0.0-37-generic
lxc_features:
cgroup2: "false"
mount_injection_file: "true"
network_gateway_device_route: "true"
network_ipvlan: "true"
network_l2proxy: "true"
network_phys_macvlan_mtu: "true"
network_veth_router: "true"
seccomp_notify: "true"
project: client-rumblepack
server: lxd
server_clustered: false
server_name: borderbound3
server_pid: 16008
server_version: "3.21"
storage: zfs
storage_version: 0.7.12-1ubuntu5

Information to attach

[ ] Any relevant kernel output (dmesg)
[ ] Container log (lxc info NAME --show-log)
[ ] Container configuration (lxc config show NAME --expanded)
[ ] Main daemon log (at /var/log/lxd/lxd.log or /var/snap/lxd/common/lxd/logs/lxd.log)
[ ] Output of the client with --debug
[ ] Output of the daemon with --debug (alternatively output of lxc monitor while reproducing the issue)

66hades commented 4 years ago

I think I found where the problem is, in the bash script for lxd-client. I'm confident I can fix this over the weekend 😊

stgraber commented 4 years ago

Cool, a PR would be quite welcome.

It should indeed be pretty straightforward to add that subcommand to scripts/bash/lxd-client.

canonical / lxd

Tab Complete Options for "lxc project ..." #6912

Issue description

Steps to reproduce

Required information

Information to attach