canonical / maas-anvil

A snap for managing charmed MAAS deployments.
https://maas.io
Apache License 2.0
3 stars 7 forks source link

Remove --accept-defaults flag from the cluster join command #73

Closed dgtlntv closed 1 month ago

dgtlntv commented 1 month ago

The configuration of the cluster should be set on the bootstrap node. So it seems to be a bug that the --accept-defaults flag exists on the cluster join command, as there should be nothing for the joining node to accept defaults from.

skatsaounis commented 1 month ago

What about bootstrapping the first node only as database and then joining a second node as haproxy? The prompt for haproxy will appear only when joining the second node. So it is valid to say that instead of getting the prompt, you want to accept the defaults during join. Is this a fair point for the continuity of the --acept-defaults flag in the cluster join command?

dgtlntv commented 1 month ago

Ah yeah, that makes sense. Thanks for answering! :)