search

canonical / maas-ui

The UI for MAAS (metal-as-a-service)
https://maas.io
Other
49 stars 47 forks source link

Enable sentry integration for react router history #1424

Open squidsoup opened 4 years ago

squidsoup commented 4 years ago

See: https://github.com/getsentry/sentry-javascript/pull/2759

huwshimi commented 4 years ago

This is the integration guide: https://docs.sentry.io/platforms/javascript/guides/react/integrations/react-router/

Looks like they also have an integration with redux: https://docs.sentry.io/platforms/javascript/guides/react/integrations/redux/

Our problem is that the integrations need to be set up earlier in the setup (currently we do the init in App.js), but we need to first check if analytics is enabled over the API.

Maybe we could use the beforeSend function to check: https://docs.sentry.io/platforms/javascript/guides/react/configuration/filtering/#using-before-send

petermakowski commented 2 years ago

It seems that these integrations may require Performance Monitoring to be enabled for them to work correctly.

Performance Monitoring requires upgrading sentry from our 9.1.2 version - we're using the latest stable snap https://snapcraft.io/sentry).

There may be some workarounds but not sure it makes sense investing in custom solutions that will become obsolete as soon as we upgrade.

Related: [Canonical IS Portal | Sentry upgrade request for Performance Monitoring]

petermakowski commented 1 year ago

blocked by https://github.com/canonical/maas-ui/issues/3932