canonical / maas-ui

The UI for MAAS (metal-as-a-service)
https://maas.io
Other
49 stars 48 forks source link

Build: Add machine does not show all supported options #1884

Closed amylily1011 closed 1 year ago

amylily1011 commented 3 years ago

Zeplin: https://zpl.io/257xZ78

https://github.com/canonical-web-and-design/maas-ui/issues/1570

Bug originally filed by ltrager at https://bugs.launchpad.net/bugs/1887699

I was helping a customer setup MAAS and I realized that a number of options available on the API when adding a new machine are missing from the UI. Options that are missing include whether commissioning runs, what custom commissioning scripts run, and whether the BMC is configured. I believe these were omitted due to space, I'm creating this bug to revisit that decision since we are adding collapsible options to deploying.

Missing options:

:param commission: Optional. Request the newly created machine to be created with status set to COMMISSIONING. Machines will wait for COMMISSIONING results and not time out. :type commission: Boolean

:param enable_ssh: Optional. Whether to enable SSH for the commissioning environment using the user's SSH key(s). '1' == True, '0' == False. :type enable_ssh: Int

:param skip_bmc_config: Optional. Whether to skip re-configuration of the BMC for IPMI based machines. '1' == True, '0' == False. :type skip_bmc_config: Int

:param commissioning_scripts: Optional. A comma seperated list of commissioning script names and tags to be run. By default all custom commissioning scripts are run. Built-in commissioning scripts always run. Selecting 'update_firmware' or 'configure_hba' will run firmware updates or configure HBA's on matching machines. :type commissioning_scripts: String

:param testing_scripts: Optional. A comma seperated list of testing script names and tags to be run. By default all tests tagged 'commissioning' will be run. Set to 'none' to disable running tests. :type testing_scripts: String

:param description: Optional. A optional description. :type description: String

Design: https://zpl.io/257xZ78

Info: We have decided to go with one column design because we want to prepare this form for the layout work in MAAS information architecture work, where we will focus on form scalability. We've tried a few variations for the column design and realized that either solution will make the form longer than the window size anyway, so the length of the form is not the biggest priority in this design. However, if sticking to the 2-column format takes lesser engineering time, I'm happy to proceed with that option :) .

tmerten commented 1 year ago

This is now tracked here: https://bugs.launchpad.net/maas-ui/+bug/1887699