search

canonical / maas-ui

The UI for MAAS (metal-as-a-service)
https://maas.io
Other
49 stars 47 forks source link

MAAS DNS GUI doesnt work with duplicates #2644

Open webteam-app opened 3 years ago

webteam-app commented 3 years ago

Bug originally filed by kruisdraad at https://bugs.launchpad.net/bugs/1919024

condition:

Go to DNS and add 2 records:

LB IN A 1.1.1.1 LB IN A 1.1.1.2

This is a totally legit DNS configuration.

However if you edit the record of 1.1.1.2 to 1.1.1.3, both records are updated. Deleting one, deleted both.

Expectation:

Records should be edited in combo. My guess is the GUI uses the name field to select the right record and does not assume duplicates. The selection should be extended for the full record and its replacement to prevent other records to be editted

Caleb-Ellis commented 3 years ago

I can fix this by replacing all the "address_record" methods with the "dnsresource" methods, but a lot of logic gets moved into the UI. Waiting on an answer from core on whether they can fix it in the backend.

Caleb-Ellis commented 3 years ago

As per the email to the MAAS-design mailing list, we'll leave this for now while the core team come up with a mini-spec for updating the websocket api.