canonical / maas-ui

The UI for MAAS (metal-as-a-service)
https://maas.io
Other
49 stars 48 forks source link

"Controllers have different installation sources." is not shown on the controllers page #2697

Closed webteam-app closed 2 years ago

webteam-app commented 3 years ago

Bug originally filed by bjornt at https://bugs.launchpad.net/bugs/1929973

This is with MAAS 3.0.0~rc2-10020-g.8cfccc212

On a snap deployment, I added a rack controller installed from a debian package. I now see a warning:

Controllers have different installation sources. Review controllers.

However, If I go to the controllers page, there's no warning, and no indication that anything is wrong.

huwshimi commented 3 years ago

Hi @bjornt that message comes from the API:

https://git.launchpad.net/maas/tree/src/maasserver/models/controllerinfo.py#n335

Did you dismiss it before you went to the details page?

bjornt commented 3 years ago

On Sun, May 30, 2021 at 04:36:32PM -0700, huwshimi wrote:

Hi @bjornt that message comes from the API:

https://git.launchpad.net/maas/tree/src/maasserver/models/controllerinfo.py#n335

Did you dismiss it before you went to the details page?

No, I don't think I dismissed it. And if I go to another page, the notification is still there.

-- Björn Tillenius | http://tillenius.me/

huwshimi commented 3 years ago

@bjornt ah ha, the notifications from the API are only displayed on list pages in the angular app. Can you think if there might be a reason why it was done that way?

Caleb-Ellis commented 2 years ago

This will be fixed as part of the controller details React migration