feat(zones): fetch zones using react-query MAASENG-3404 - Githubissues

canonical / maas-ui

The UI for MAAS (metal-as-a-service)

https://maas.io

Other

49 stars 48 forks source link

feat(zones): fetch zones using react-query MAASENG-3404 #5485

Closed petermakowski closed 3 months ago

petermakowski commented 3 months ago

Done

This PR introduces React Query for managing zone-related data fetching and caching.

Add WebSocketEndpoints detailing allowed WebSocket endpoint models and methods
Move from Redux state management to React Query for handling zones-related data
Removed unused imports and code related to fetching zones
Refactored code to use new useZoneById hook for fetching zones by ID
Update testing utilities to support React Query and WebSocket testing
Add new helper functions in testing/utils for setting up initial state and query data
Modified renderWithBrowserRouter to return store and queryClient for more concise tests

QA steps

[ ] Go to AZs page and verify zones are fetched correctly using react-query
[ ] Add a new zone
[ ] Verify it appears on the list
[ ] Check that all zone-related components display data properly
[ ] Test websocket functionality with zone updates
[ ] Ensure msw is working as expected in development environment

Fixes

Fixes: MAASENG-3404

webteam-app commented 3 months ago

Demo

Jenkins

demos.haus

ndv99 commented 3 months ago

Looks like lint is failing on this at the moment

petermakowski commented 3 months ago

Looks like lint is failing on this at the moment

Please have a look regardless, this PR is pretty big. :)

ndv99 commented 3 months ago

QA is looking good. New zones / modified zones have a bit of delay in waiting for the changes to propagate, but that might just be my slow connection