fix: Prevent query client from fetching zones excessively on page load - Githubissues

canonical / maas-ui

The UI for MAAS (metal-as-a-service)

https://maas.io

Other

52 stars 51 forks source link

fix: Prevent query client from fetching zones excessively on page load #5510

Closed ndv99 closed 3 months ago

ndv99 commented 4 months ago

Done

Removed useEffect in useWebsocketAwareQuery that was causing the zones endpoint to be fetched 50 times on page load
Added TODO comment with a linked jira ticket to investigate this in future and determine if this code is needed

QA steps

[ ] Go to the UI and open dev tools
[ ] Fully refresh the page (ctrl + F5), and ensure the zones endpoint is only called once
[ ] Go to zones ("AZs"), and create/update/delete a zone
[ ] Ensure that the zones list is automatically updated after each of these operations, without needing a page refresh

Screenshots

This is how the network tools looked on initial page load for labmaas:

webteam-app commented 4 months ago

Demo

Jenkins

demos.haus

ndv99 commented 3 months ago

Closed, as this has been superseded by https://github.com/canonical/maas-ui/pull/5518