canonical / maas.io

Site for maas.io

https://maas.io/

GNU Lesser General Public License v3.0

16 stars 42 forks source link

remove jQuery scripts #696

Closed petermakowski closed 2 years ago

petermakowski commented 2 years ago

Done

remove jquery from the site entirely
move venobox modal script to the tour page, reducing size for all other pages

jquery use in maas.io

scripts in head.html:

<script src="/static/js/jquery.modal.min.js" defer></script> jquery venobox modal, refactored and replaced with vanilla js version
<script src="/static/js/jquery.command-line.js" defer></script> removed does not appear to be used (queries the DOM for .p-code-copyable which does not appear anywhere in maas.io)
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js"></script> removed

QA

Go to the /tour page and
ensure all images still open the modal correctly (you can compare with the current version - https://maas.io/tour )

Issue / Card

653

Screenshots

Before

After

webteam-app commented 2 years ago

Demo starting at https://maas-io-696.demos.haus

huwshimi commented 2 years ago

It appears the new modal is displaying the image at the top of the screen instead of the centre:

Screen Shot 2022-02-16 at 3 44 26 pm

Old:

Screen Shot 2022-02-16 at 3 44 04 pm

petermakowski commented 2 years ago

It appears the new modal is displaying the image at the top of the screen instead of the centre:

Good spot! Updated.

petermakowski commented 2 years ago

Could you take another look @huwshimi please 🙏