chore(deps): update @canonical/global-nav to v3

renovate[bot] commented 2 years ago

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@canonical/global-nav	`2.7.0` -> `3.2.4`

Release Notes

canonical-web-and-design/global-nav

### [`v3.2.4`](https://togithub.com/canonical-web-and-design/global-nav/compare/0c6afaad42651d85c8afd82d6ca652ed3c285dca...7b70a84471ef37c5f8f5af0c18c81326063b61e5) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/0c6afaad42651d85c8afd82d6ca652ed3c285dca...7b70a84471ef37c5f8f5af0c18c81326063b61e5) ### [`v3.2.3`](https://togithub.com/canonical-web-and-design/global-nav/compare/87f6d73a205c4b6cbd6a245077fbb868435bc68f...0c6afaad42651d85c8afd82d6ca652ed3c285dca) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/87f6d73a205c4b6cbd6a245077fbb868435bc68f...0c6afaad42651d85c8afd82d6ca652ed3c285dca) ### [`v3.2.1`](https://togithub.com/canonical-web-and-design/global-nav/compare/v3.2.0...87f6d73a205c4b6cbd6a245077fbb868435bc68f) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/v3.2.0...87f6d73a205c4b6cbd6a245077fbb868435bc68f) ### [`v3.2.0`](https://togithub.com/canonical/global-nav/releases/tag/v3.2.0): v.3.2.0 [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/44ca3428e78c6590b73f7e792d6afbd9b978d6ed...v3.2.0) ##### :bomb: Breaking changes This version radically changes the appearance and location of the global nav - it no longer appears as a separate element above the rest of the page content, instead it is added to a site's main navigation, and on mobile appears as a child item of the main menu dropdown. ##### :rocket: Features - Updated the look and placement of the global nav to work with and be part of the updated navigation pattern in Vanilla ### [`v3.1.4`](https://togithub.com/canonical-web-and-design/global-nav/compare/5d5a6471872ac746e0c09df430458dadb577a8ff...44ca3428e78c6590b73f7e792d6afbd9b978d6ed) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/5d5a6471872ac746e0c09df430458dadb577a8ff...44ca3428e78c6590b73f7e792d6afbd9b978d6ed) ### [`v3.1.3`](https://togithub.com/canonical-web-and-design/global-nav/compare/717b3e7c2cbe3ee0d0f74726cbea0990aa463008...5d5a6471872ac746e0c09df430458dadb577a8ff) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/717b3e7c2cbe3ee0d0f74726cbea0990aa463008...5d5a6471872ac746e0c09df430458dadb577a8ff) ### [`v3.1.2`](https://togithub.com/canonical-web-and-design/global-nav/compare/c6f0ed49ead23776045a7d87c5b9dc2eeffc5bed...717b3e7c2cbe3ee0d0f74726cbea0990aa463008) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/c6f0ed49ead23776045a7d87c5b9dc2eeffc5bed...717b3e7c2cbe3ee0d0f74726cbea0990aa463008) ### [`v3.1.1`](https://togithub.com/canonical-web-and-design/global-nav/compare/f9a6c0be1baaf0a163fb49c1414546d36375a6a7...c6f0ed49ead23776045a7d87c5b9dc2eeffc5bed) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/f9a6c0be1baaf0a163fb49c1414546d36375a6a7...c6f0ed49ead23776045a7d87c5b9dc2eeffc5bed) ### [`v3.1.0`](https://togithub.com/canonical-web-and-design/global-nav/compare/9b573d1d61eb1e958726c8c50a5f1c6f8cdfcb94...f9a6c0be1baaf0a163fb49c1414546d36375a6a7) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/9b573d1d61eb1e958726c8c50a5f1c6f8cdfcb94...f9a6c0be1baaf0a163fb49c1414546d36375a6a7) ### [`v3.0.0`](https://togithub.com/canonical-web-and-design/global-nav/compare/906697497262e73208566393cf8db39248276634...9b573d1d61eb1e958726c8c50a5f1c6f8cdfcb94) [Compare Source](https://togithub.com/canonical-web-and-design/global-nav/compare/906697497262e73208566393cf8db39248276634...9b573d1d61eb1e958726c8c50a5f1c6f8cdfcb94)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

webteam-app commented 2 years ago

renovate[bot] is not a collaborator of the repo

petermakowski commented 2 years ago

https://maas-io-754.demos.haus/

petermakowski commented 2 years ago

v3 of global nav changes the behaviour by removing the extra Canonical strip and moving canonical products dropdown to the main navigation strip. In the case of maas.io where we have lots of items already this might need some input from one of our designers.

the first (darker) strip above is removed from the version 3 of global-nav and the Products dropdown is moved to the main navigation (white background)

Items do not fit in a single row after upgrade

petermakowski commented 2 years ago

This is currently being worked on by @davegoddard42 and @rayito and is blocked until design work is complete.

codecov-commenter commented 1 year ago

Codecov Report

Merging #754 (5d1b71b) into main (67460e3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5d1b71b differs from pull request most recent head eb24c9d. Consider uploading reports for the commit eb24c9d to get more accurate results

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files           8        8           
  Lines         193      193           
=======================================
  Hits          119      119           
  Misses         74       74

Flag	Coverage Δ
python	`61.65% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

anthonydillon commented 1 year ago

@petermakowski is there something we can do to move this forward?

petermakowski commented 1 year ago

@dgtlntv Could you please help with this? Navigation Items do not fit in a single row after upgrade, any suggestions how we should proceed?

One idea would be to move some items to a single dropdown so that we have enough space to display the global navigation item "All Canonical".

More details in the comment above: https://github.com/canonical/maas.io/pull/754#issuecomment-1207819194

renovate[bot] commented 1 year ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

dgtlntv commented 1 year ago

@juanruitina and I propose the following changes to adapt to the new navigation and improve navigation in general.

Renaming Tour to Features to use more common terminology and be more consistent with other products where we also call it Features. Renaming Resources to Understand MAAS as we feel this better describes what you can expect on this page, and it is also the h1 of that page. Finally, renaming Discourse to Forum because, again, we feel this is a more familiar term that users will know even if they don't know Discourse. Contact us is ranked rather low in terms of traffic, so we felt that this page would probably offer more value in context than if it were in the navigation bar. The contact page would still be available in the footer and as part of normal content throughout maas.io, all though we will revisit this if we see an impact to traffic to the contact page.

To avoid the issue of too many items in the navigation bar, we propose to move learning content to a drop-down menu called Learn ( similarly to what we do on juju.is), while keeping the most visited pages as navigation items. See the screenshot for reference + screens on zeplin.

petermakowski commented 1 year ago

Completed in https://github.com/canonical/maas.io/pull/787

renovate[bot] commented 1 year ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

canonical / maas.io