Closed renovate[bot] closed 2 years ago
Demo starting at https://maas-io-762.demos.haus
Merging #762 (f51cf0b) into main (3642fd4) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 63.60% 63.60%
=======================================
Files 6 6
Lines 327 327
=======================================
Hits 208 208
Misses 119 119
Flag | Coverage Ξ | |
---|---|---|
python | 63.60% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
We will need to fix the logo size (potentially align the classes we use with latest Vanilla) before we merge this.
To reiterate what was discussed privately (for public reference):
The p-navigation__logo-icon
class expects a square icon SVG - ours is a rectangle. We need to either get the SVG updated, or find out where we can get a square SVG with just the white logo, similar to the Ubuntu logo
To reiterate what was discussed privately (for public reference):
The
p-navigation__logo-icon
class expects a square icon SVG - ours is a rectangle. We need to either get the SVG updated, or find out where we can get a square SVG with just the white logo, similar to the Ubuntu logo
@ndv99 Have you tried https://assets.ubuntu.com/v1/0a863174-MAAS+logomark+only.svg
That kinda works yeah, although it appears a bit bigger than it does in main
:
Edit: Tbh this is more consistent with what we have on the actual UI as well, so personally I think this is fine. Might be worth checking with Lyubo though
This PR contains the following updates:
3.8.0
->3.8.1
Configuration
π Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.