search

canonical / maas.io

Site for maas.io
https://maas.io/
GNU Lesser General Public License v3.0
17 stars 42 forks source link

Fix video scaling on / #775

Closed petesfrench closed 1 year ago

petesfrench commented 1 year ago

Done

QA

Go to https://maas-io-775.demos.haus/ Check that on medium sized screens the videos spans across all available grids

Issue / Card

https://github.com/canonical/maas.io/issues/774

Screenshots

image

webteam-app commented 1 year ago

Demo starting at https://maas-io-775.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #775 (8ca49ae) into main (fdf3777) will increase coverage by 0.00%. The diff coverage is 66.66%.

:exclamation: Current head 8ca49ae differs from pull request most recent head 38401c1. Consider uploading reports for the commit 38401c1 to get more accurate results

@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   65.55%   65.56%           
=======================================
  Files           8        8           
  Lines         360      363    +3     
=======================================
+ Hits          236      238    +2     
- Misses        124      125    +1
Flag Coverage Δ
python 65.56% <66.66%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/app.py 69.86% <66.66%> (-0.14%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ndv99 commented 1 year ago

QA looks good on this - just checking, is the video meant to disappear on small screens? It vanishes when the screen width is < 620px

petesfrench commented 1 year ago

Hey @ndv99, this was the behavior it already had so I just left it as is. Hiding images and videos on small screens is typical across a lot of our sites. so makes sense here also.

ndv99 commented 1 year ago

No worries at all, just making sure. LGTM!