canonical / maas.io

Site for maas.io
https://maas.io/
GNU Lesser General Public License v3.0
17 stars 42 forks source link

Fix sidebar navigation for api #785

Closed sparkiegeek closed 1 year ago

sparkiegeek commented 1 year ago

Done

Copied boilerplate navigation function to api template

QA

Issue / Card

[List of links to Github issues/bugs and cards if needed - e.g. Fixes #1]

Screenshots

webteam-app commented 1 year ago

Demo starting at https://maas-io-785.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #785 (6c0219e) into main (f885924) will decrease coverage by 3.91%. The diff coverage is 69.38%.

:exclamation: Current head 6c0219e differs from pull request most recent head 1a5e58e. Consider uploading reports for the commit 1a5e58e to get more accurate results

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   65.56%   61.65%   -3.91%     
==========================================
  Files           8        8              
  Lines         363      193     -170     
==========================================
- Hits          238      119     -119     
+ Misses        125       74      -51     
Flag Coverage Δ
python 61.65% <69.38%> (-3.91%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/views/tutorials.py 43.47% <43.47%> (ø)
webapp/app.py 85.10% <85.71%> (+15.24%) :arrow_up:
webapp/openapi_parser.py 94.44% <100.00%> (+0.32%) :arrow_up:
webapp/views/docs.py 100.00% <100.00%> (ø)
petermakowski commented 1 year ago

Tested it locally, QA +1

petermakowski commented 1 year ago

Incorrect navigation item seems to be highlighted when on /docs/api, but that's likely due to the fact that we use an absolute link to https://maas.io/docs/api