search

canonical / microceph

Ceph for a one-rack cluster and appliances
https://snapcraft.io/microceph
GNU Affero General Public License v3.0
193 stars 27 forks source link

Version: set meaningful version string #284

Closed sabaini closed 5 months ago

sabaini commented 5 months ago

Build version string from Ceph package version, suffixed by snap git hash

UtkarshBhatthere commented 5 months ago

@sabaini although this change sets the version string correctly in the built artifact name. The output of sudo microceph --version does not seem to be correct.

utkarsh@workbook:~/Downloads/snaps$ sudo snap install ./microceph_18.2.0+snap6e88a3f350_amd64.snap --dangerous
microceph 18.2.0+snap6e88a3f350 installed
utkarsh@workbook:~/Downloads/snaps$ sudo microceph --version
0.1

I believe this is not desired ?

sabaini commented 5 months ago

@sabaini although this change sets the version string correctly in the built artifact name. The output of sudo microceph --version does not seem to be correct.

utkarsh@workbook:~/Downloads/snaps$ sudo snap install ./microceph_18.2.0+snap6e88a3f350_amd64.snap --dangerous
microceph 18.2.0+snap6e88a3f350 installed
utkarsh@workbook:~/Downloads/snaps$ sudo microceph --version
0.1

I believe this is not desired ?

Thanks @UtkarshBhatthere , good catch. I've now pushed an update that also sets the version at build time so that microceph --version provides accurate output

microceph --version
ceph-version: 18.2.0-0ubuntu3~cloud0; microceph-git: 43ecfe674b-dirty
UtkarshBhatthere commented 5 months ago

Awesome! Thanks for PR @sabaini