Fix #303: Introduce flag --microceph-ip for cluster bootstrap

canonical / microceph

Ceph for a one-rack cluster and appliances

https://snapcraft.io/microceph

GNU Affero General Public License v3.0

193 stars 27 forks source link

Fix #303: Introduce flag --microceph-ip for cluster bootstrap #304

Closed krombel closed 4 months ago

krombel commented 4 months ago

Fixes #303

sabaini commented 4 months ago

@krombel there's a bit of test flakiness i.e. false negatives here which seem unrelated to your change. However we would need a contributor licence and have the commit signed before we can merge I'm afraid. Cf. https://ubuntu.com/legal/contributors for details.

krombel commented 4 months ago

signed the commit and the CLA

sabaini commented 4 months ago

Hey @krombel it looks like the CLA check still fails. From the log messages it says (redacted):

Checking the following users on Launchpad:
- <...>@<...>.de ✕ (has no Launchpad account)

krombel commented 4 months ago

Can you rerun the CLA test? As of a few minutes ago I think it should be working now

sabaini commented 4 months ago

Thank you @krombel !