search

canonical / microcloud

Automated private cloud based on LXD, Ceph and OVN
https://microcloud.is
GNU Affero General Public License v3.0
260 stars 36 forks source link

test/includes/microcloud: Remove `core.trust_password` support #323

Closed roosterfish closed 2 weeks ago

roosterfish commented 3 weeks ago

This is required after https://github.com/canonical/lxd/pull/13567. Instead of the password we now have to use a token when adding the remote.

roosterfish commented 2 weeks ago

Will mark as draft until I have finalized the testing on my end.

roosterfish commented 2 weeks ago

That is now ready for a final review. I have tested forming LXD clusters in version 5.21 (prior to password removal) and edge.

There was an error in the HasExtension check as it will always return true if the underlying LXD client has never before done a call to GetServer() which will fetch and cache the API extensions. See https://github.com/canonical/lxd/blob/main/client/lxd_server.go#L62. A fix for this is added to this PR.

roosterfish commented 2 weeks ago

The pipeline is now failing due to a regression caused by https://github.com/canonical/lxd-pkg-snap/pull/471.

simondeziel commented 2 weeks ago

The pipeline is now failing due to a regression caused by canonical/lxd-pkg-snap#471.

This was fixed by https://github.com/canonical/lxd-pkg-snap/pull/476 and now tests are working.