search

canonical / microcloud

Automated private cloud based on LXD, Ceph and OVN
https://microcloud.is
GNU Affero General Public License v3.0
260 stars 36 forks source link

Include 'lookup_interface' in preseed example and Use the correct ovn interface #328

Closed WizardBit closed 1 week ago

WizardBit commented 2 weeks ago

The preseed yaml file used as an example in the docs does not include the option 'lookup_subnet'.

As this preseed example closely aligns with the get started guide eth1 was changed to enp6s0 to avoid confusion with the device name added to the VM.

Not included in this PR, as I cannot find additional information on the behavior, is reuse_existing_clusters which is also missing.

roosterfish commented 2 weeks ago

@WizardBit thanks for your contribution.

Your mail 82845986+WizardBit@users.noreply.github.com is failing the CLA check. Could you please use another one?

In the commit messages we put a prefix which makes it easier to identify the change in the long list of commits. See https://github.com/canonical/microcloud/commit/48695e6 as an example.

WizardBit commented 2 weeks ago

@roosterfish Thank you for the clarification and glad to help add this missing option.

roosterfish commented 1 week ago

Thanks for changing the mail, just one more thing. Can you please squash the two commits together? It is so that you don't add stuff and delete it in the next commit again.

roosterfish commented 1 week ago

LGTM!

@WizardBit it looks that GitHub doesn't recognize the signing key that you have used. Have you added the key also to https://github.com/settings/keys under "Signing keys"?