Fix the --set-as-default-runtime deprecation warning

Damowerko commented 8 months ago

Fixes #269.

I believe the previously intended behavior was to check if the two flags are different, but the default value of --set-as-default-runtime was None, so the if statement on line 210 evaluated to True by default. Changed it the warning is written whenever the old flag is set to any value, regardless of the new flag.

Thank you for making MicroK8s better

Please reference the issue this PR is fixing, or provide a description of the problem addressed.

Also verify you have:

[x] Read the contributions page.
[x] Submitted the CLA form, if you are a first time contributor.

berkayoz commented 7 months ago

@neoaggelos This should fix #272 as well since the default value for set-as-default-runtime seems to be False which overrides the default True of gpu-operator-set-as-default-runtime flag within this if clause.

neoaggelos commented 7 months ago

Thank you @Damowerko, could you also make sure to create a Launchpad account and sign the CLA? Then we can merge this PR.

beliaev-maksim commented 6 months ago

You don't need a Launchpad account to sign CLA

Damowerko commented 6 months ago

I hope the CLA wasn't a problem. I signed it but for some reason the tests weren't passing.

canonical / microk8s-core-addons

Fix the --set-as-default-runtime deprecation warning #270

Thank you for making MicroK8s better