Apply /contact-us redesign

canonical / microk8s.io

Code for the microk8s.io website by Canonical

https://microk8s.io

18 stars 63 forks source link

Apply /contact-us redesign #611

Closed mtruj013 closed 1 year ago

mtruj013 commented 1 year ago

Done

Applied redesign as per doc and design

QA

View the site locally in your web browser at: https://microk8s-io-611.demos.haus/contact-us
Check against doc and design

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-4196

webteam-app commented 1 year ago

Demo starting at https://microk8s-io-611.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #611 (3d7df9f) into microk8s-refresh (aceaf40) will not change coverage. Report is 1 commits behind head on microk8s-refresh. The diff coverage is n/a.

:exclamation: Current head 3d7df9f differs from pull request most recent head e58c048. Consider uploading reports for the commit e58c048 to get more accurate results

@@                Coverage Diff                @@
##           microk8s-refresh     #611   +/-   ##
=================================================
  Coverage             72.58%   72.58%           
=================================================
  Files                     2        2           
  Lines                    62       62           
=================================================
  Hits                     45       45           
  Misses                   17       17

Flag	Coverage Δ
python	`72.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

lyubomir-popov commented 1 year ago

looks great, thanks @mtruj013

juanruitina commented 1 year ago

On mobile, the consent checkbox and the label are not aligned.
Can you please add a bit of space between that and the "By submitting this form..." line, to make clear they are not related?

LGTM otherwise!

lyubomir-popov commented 1 year ago

Looks great @mtruj013 a coiupel of small things on small screens - giving a +1 for easier merging after those are resolved:

Do we need those p-lists? They insert arbitrary space between form fields on mobile:

I would add is-split-on-medium to all secitons on this page (and also wrap text in paragraphs so there's some margin and padding on them - otherwise they sit too close to the horizontal rules):

mtruj013 commented 1 year ago

Thanks all! @juanruitina and @anthonydillon could you take another look? Sophie solved the marketo fields issue, we're using a new form so the id has been updated

mtruj013 commented 1 year ago

Thanks @anthonydillon, could you take another look? I updated the required fields to use the Vanilla pattern, but omitted the legend as this is already accounted for in the copy ("* Mandatory field" further down in the page)

juanruitina commented 1 year ago

LGTM!