canonical / microk8s.io

Code for the microk8s.io website by Canonical
https://microk8s.io
18 stars 63 forks source link

Apply redesign to nav and footer #614

Closed mtruj013 closed 1 year ago

mtruj013 commented 1 year ago

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-5794

webteam-app commented 1 year ago

Demo starting at https://microk8s-io-614.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #614 (ef7818e) into microk8s-refresh (aceaf40) will not change coverage. Report is 1 commits behind head on microk8s-refresh. The diff coverage is n/a.

:exclamation: Current head ef7818e differs from pull request most recent head c70c969. Consider uploading reports for the commit c70c969 to get more accurate results

@@                Coverage Diff                @@
##           microk8s-refresh     #614   +/-   ##
=================================================
  Coverage             72.58%   72.58%           
=================================================
  Files                     2        2           
  Lines                    62       62           
=================================================
  Hits                     45       45           
  Misses                   17       17           
Flag Coverage Δ
python 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

mtruj013 commented 1 year ago

Thanks @anthonydillon, fixed! Could you take a look again?

anthonydillon commented 1 year ago

Thanks for the fixes @mtruj013 Looks and works great!

lyubomir-popov commented 1 year ago

u-no-margin--bottom here please:

image

(driveby)

logo too indented here:

image

menu items should align under the wordmark microk8s (coukld be a vanilla bug)

would be nice to retain some layout on medium screens, e.g.:

image
mtruj013 commented 1 year ago

@lyubomir-popov ready for another look

lyubomir-popov commented 1 year ago

LGTM, thanks @mtruj013 . can I as kfor a driveby - add u-no-margin-bottom on the landing page h1

mtruj013 commented 1 year ago

@lyubomir-popov sorry, totally thought I'd added it. It's there now

lyubomir-popov commented 1 year ago

we need to fix this somewhere too:

image
juanruitina commented 1 year ago

Lovely to see the new navigation and footer. We need however to implement the sliding navigation here so the global nav shows up as it should on mobile: as only one item you can then open. You can see what I mean here on Figma. @petesfrench might be able to help with the implementation, he is familiar with it.

petesfrench commented 1 year ago

Lovely to see the new navigation and footer. We need however to implement the sliding navigation here so the global nav shows up as it should on mobile: as only one item you can then open. You can see what I mean here on Figma. @petesfrench might be able to help with the implementation, he is familiar with it.

Happy to help with this, but the best course of action would be to implement it on the global-nav itself. This needs to be done at one point and will mean it is available across all projects.

mtruj013 commented 1 year ago

re: sliding navigation in the global nav. It was decided during stand-up the this will be updated directly on the global-nav, we will go live with this site as is

@juanruitina would you mind giving UX+1 if all else is well?